Question

iron and titanium are two elements that are used to make sparks and zinc is used in compounds to make smoke. which other elements could you use in compounds to make a firework that produced green and red sparks and finished with blue smoke?

Answer 1

Phosphorus and sulphur , maybe the answer

Answer 2

Barium compounds produce green colors when heated, copper salts produce green and blue flames, sodium salts are yellow in flame, lithium compounds produce red colors, magnesium metal produces brilliant white light when burned and strontium  compounds produce brilliant red colors.