what is smudge effect crop an image and scaling on image
Answers
Answered by
6
hey mate! here is ur answer...
Problem/Motivation
It would be useful if the Scale and Crop image effect had an anchor option, similar to the basic Crop image effect. The anchor type, such as "center-center", is used to set the top left coordinates of the crop area. Currently, Scale and Crop crops only to the center of an image.
Proposed resolution
Have the ScaleAndCropImageEffect descend from CropImageEffect which provides the anchor option, (rather than ScaleImageEffect which it descends from currently) and do the extra math.
Remaining tasks
Write patch with testsReviewCommit!
User interface changes
The "Scale and crop" image effect now gives the option of choosing an anchor - it works exactly like the "Crop" image effect (which the plugin is descending from).
API changes
This adds a backwards compatible change to the 'scale_and_crop' image toolkit operation: it now can optionally accept 'x' and 'y' arguments to give an offset.
This really only affects people who are implementing image toolkits (like the ImageMagick module), who will need to do something with these arguments if provided.
Data model changes
This adds the "anchor" key to the plugin configuration for this image effect. The default value is "center-center" which matches the old behavior, so if someone imports an images style which with a "Scale and crop" effect that doesn't have the "anchor" key, it'll automatically get set to "center-center".
In short, old configuration will continue to import just fine with no change in behavior.
But tests that look at the configuration will see the new key, and on export the new key will be added. This is the cause of the majority of the test changes, and the changes to the config files in the demo_umami profile.
Problem/Motivation
It would be useful if the Scale and Crop image effect had an anchor option, similar to the basic Crop image effect. The anchor type, such as "center-center", is used to set the top left coordinates of the crop area. Currently, Scale and Crop crops only to the center of an image.
Proposed resolution
Have the ScaleAndCropImageEffect descend from CropImageEffect which provides the anchor option, (rather than ScaleImageEffect which it descends from currently) and do the extra math.
Remaining tasks
Write patch with testsReviewCommit!
User interface changes
The "Scale and crop" image effect now gives the option of choosing an anchor - it works exactly like the "Crop" image effect (which the plugin is descending from).
API changes
This adds a backwards compatible change to the 'scale_and_crop' image toolkit operation: it now can optionally accept 'x' and 'y' arguments to give an offset.
This really only affects people who are implementing image toolkits (like the ImageMagick module), who will need to do something with these arguments if provided.
Data model changes
This adds the "anchor" key to the plugin configuration for this image effect. The default value is "center-center" which matches the old behavior, so if someone imports an images style which with a "Scale and crop" effect that doesn't have the "anchor" key, it'll automatically get set to "center-center".
In short, old configuration will continue to import just fine with no change in behavior.
But tests that look at the configuration will see the new key, and on export the new key will be added. This is the cause of the majority of the test changes, and the changes to the config files in the demo_umami profile.
Similar questions
Science,
7 months ago
Business Studies,
7 months ago
Chemistry,
1 year ago
English,
1 year ago
Math,
1 year ago