Question

dash is the name of a numeric variable and dash is a string variable

Answer 1

Dash1 is a numeric variable that identifies the location of the first hyphen in EmployeeID (and later dash variables identify the first hyphen in the ever-shrinking employrem). 
CHAR.INDEX(EmployeeID,'-') finds the first '-' in the string in EmployeeID