Question

if proton have positive charge and electron has negative then why they do not attract each other?

Answer 1

They are attracted towards each other therefore the electrons revolve around them.

Answer 2

Since the same charge repels each other but the opposite charges attract each other.If a solitary positive proton and negative electron placed near each other they will come together to come to form a hydrogenatom